Ensure types.d.ts is bundled with preact-cli
#1636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version on npm (v3.3.3) does not bundle the types.d.ts file I have copied it into my local type declarations, but it would be nice for it to be included in the package as well.
|
Member
|
Duplicate of #1634 |
Author
Oh darn, I'm sorry, I searched issues but didn't search PR. Will close. |
Member
|
Oh certainly shouldn't apologize, it's super easy to miss. Hopefully that'll get merged in soon, and I'm glad you were happy to see types! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
package.jsonfor theclipackage to bundle the type declarationsWhat kind of change does this PR introduce?
Just a quick 1-line fix
Did you add tests for your changes?
Not sure how to test this
Summary
The current version on npm (v3.3.3) does not bundle the types.d.ts file. I was happy to see there was a
types.d.tsfile I could cop to my local environment, and thought it would be nice for it to be included in the package as well 😃.Does this PR introduce a breaking change?
I don't think so