Declare Node v6 as minimum support #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh, and normally this would be a breaking change for a library. But it isn't for us because we've already been informally requiring Node 6. This is just formally writing it down. 📝 |
rkostrzewski
approved these changes
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
engineskey will only show a warning to NPM installers. It's not perfect, but at least it's something.Although we were compiling to Node 4 and our code worked in a Node 4 environment (I just tried, dat
npm installdoe...💤 ), we have several dependencies that require 5+ and 6+ and our dependency resolution was fighting against NPM's dependency tree (typical).So with this, we're now compiling to Node 6 & actively declaring a 6+ minimum.
I removed Node 7 from Travis because we're already testing v8 and v7 literally brings nothing unique to the table. This will make tests completely a bit sooner.
References #165