check node version on postinstall & while initiating a new project

[reznord]

Fixes #169

[reznord]

Travis checks are failing because lib/lib/check-engine.js is not available.

If we update the build on travis, that would fix the tests.

[lukeed]

Nice @reznord! Thanks for all this 😄

However, how do you feel about going the much simpler route, something like this:

const pkg = require('../../package');

const version = parseFloat( process.version.substr(1) );
const minimum = parseFloat( pkg.engines.node.match(/\d+/g).join('.') );
// ^^ or just hard-code?

if (version >= minimum) {
   return true;
}

// uh oh... log & exit

[developit]

Either way process.version seems super nice here, since it makes the whole check synchronous.

[lukeed]

@developit Are you opposed to moving this check-engine.js file to the root & adding it to the NPM files?

This way, we can let the tests run without doing any fancy side stepping. Currently, this will be fine with downloads since a lib/ will already be built.

[developit]

Yup, I'm fine with that. Could almost be a node -e in scripts, but the root is good enough.

[lukeed]

Okay then, sorry @reznord 😆 😭 few changes:

• Move lib/check-engine.js to root (maybe as version.js or check.js?)

• Add the new root file to "files" in package.json

• Update the paths in scripts & src/index.js

Thank you 🙏

I can take care of this too if you don't have time.

[lukeed]

Thanks~!

[thangngoc89]

Please don't do this. babel-node is in devDeps so it would break user install. How about rewrite check.js with CommonJS modules ?

[lukeed]

Oh right. Forgot not all babel pkgs are normal deps.

Let's rewrite to ES5 and just use node.

[lukeed]

Perfecto

[thangngoc89]

@reznord Your commit message make me laugh :D

check.js (es5 version)

And you're using template literal

[reznord]

Your commit message make me laugh :D

Bad time for a commit I'd say :P (2AM) anyways, its all sorted :P

[lukeed]

Template literals ftw! 🎉