Suggest a new port for development server if default port is in use. #196
Conversation
|
Oops !! committed My bad :( |
src/lib/webpack/run-webpack.js
Outdated
| process.stdout.write(chalk.green('Compiled successfully!!\n\n')); | ||
| process.stdout.write('You can view the application in the browser.\n\n'); | ||
| process.stdout.write(chalk.green('\nCompiled successfully!!\n\n')); | ||
| if (parseInt(port, 10) !== parseInt(config.devServer.port, 10)) { |
There was a problem hiding this comment.
Showing this message only when it is not using default port. So, it will be easy for the users to understand what port it has been changed to !!
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
We should still respect the hierarchy of user-defined ports:
process.env.PORT || config.devServer.port || 8080
|
This fixes #179 |
There was a problem hiding this comment.
I forgot I could push to PRs 😅
I added changes so that we only showed the "using different port" message if user actually defined a port. Since 8080 is a default (aka, not specified) I don't think we have to warn/alert users about the change.
Also, moved parseInt call to process.env.PORT only because it's the only item that is passed in as a string.
Looks good, thanks!!
2 participants
This PR opens dev server in a new port if the default port is already in use.
Here's how it looks:
