Skip to content

enabling create app in current directory #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reznord merged 6 commits into from
Jul 12, 2017
Merged

enabling create app in current directory #200

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ab27c7
enabling create app in current directory
prateekbh Jul 7, 2017
dd34115
force option while initiating a project
reznord Jul 12, 2017
61be8c4
Fix lint errors
reznord Jul 12, 2017
11482b4
Use chalk for showing errors
reznord Jul 12, 2017
fa9b452
whitespace fix
reznord Jul 12, 2017
aa03d8c
use stderr to throw errors
reznord Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@
"get-port": "^3.1.0",
"html-webpack-exclude-assets-plugin": "0.0.5",
"html-webpack-plugin": "^2.28.0",
"inquirer": "^3.2.0",
"ip": "^1.1.5",
"isomorphic-unfetch": "^2.0.0",
"json-loader": "^0.5.4",
Expand Down
33 changes: 30 additions & 3 deletions src/commands/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import fs from 'fs.promised';
import copy from 'recursive-copy';
import mkdirp from 'mkdirp';
import ora from 'ora';
import chalk from 'chalk';
import inquirer from 'inquirer';
import promisify from 'es6-promisify';
import spawn from 'cross-spawn-promise';
import path from 'path';
Expand All @@ -29,6 +31,10 @@ export default asyncCommand({
description: 'Directory to create the app within',
defaultDescription: '<name>'
},
force: {
description: 'Force option to create the directory for the new app',
default: false
},
type: {
description: 'A project template to start from',
choices: [
Expand Down Expand Up @@ -81,16 +87,37 @@ export default asyncCommand({
}
catch (err) {}

if (exists) {
throw Error('Directory already exists.');
if (exists && argv.force) {
const question = {
type: 'confirm',
Copy link
Member

@developit developit Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace <3

name: 'enableForce',
message: `You are using '--force'. Do you wish to continue?`,
default: false,
};

let forceInit = await inquirer.prompt(question);
Copy link
Collaborator

@rkostrzewski rkostrzewski Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: let { enableForce } = , also enableForce:
enableForce


if (forceInit.enableForce) {
process.stdout.write('Initializing project in the current directory...\n');
} else {
process.stdout.write(`${chalk.red('Error:')} Cannot initialize in the current directory`);
Copy link
Collaborator

@rkostrzewski rkostrzewski Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be process.stderr.write. BTW why not color whole message to red?

process.exit(1);
}
}

if (exists && !argv.force) {
process.stdout.write(`${chalk.red('Error:')} Cannot initialize in the current directory, please specify a different destination`);
Copy link
Collaborator

@rkostrzewski rkostrzewski Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be process.stderr.write

process.exit(1);
}

let spinner = ora({
text: 'Creating project',
color: 'magenta'
}).start();

await promisify(mkdirp)(target);
if (!exists) {
await promisify(mkdirp)(target);
}

await copy(
path.resolve(__dirname, '../..', template),
Expand Down