feat: Less verbose error output #206
Conversation
src/lib/webpack/run-webpack.js
Outdated
| process.stdout.write(chalk.red('\Build failed!\n\n')); | ||
| } else { | ||
| process.stdout.write(chalk.green('\nCompiled successfully!\n\n')); | ||
| } |
There was a problem hiding this comment.
Better to expose the IP addresses & port message only when the build is successful !!
if (userPort !== port) {
process.stdout.write(`Port ${chalk.bold(userPort)} is in use, using ${chalk.bold(port)} instead\n\n`);
}
process.stdout.write('You can view the application in browser.\n\n');
process.stdout.write(`${chalk.bold('Local:')} ${serverAddr}\n`);
process.stdout.write(`${chalk.bold('On Your Network:')} ${localIpAddr}\n`);otherwise LGTM !!
There was a problem hiding this comment.
That could be possible but I don't know really. webpack-dev-server shows address always on first compilation.
We kinda don't inform users after they fixed the errors if anything occurred. Maybe the output should look like this:
You can view the application in browser.
Local: ...
On Your Network: ...
Build failed!
--Some error message--
Compiled successfully --date stamp--
Compiled successfully --date stamp--
Build failed!
--Some error message--
Compiled successfully --date stamp--
Let me know what you think (also @lukeed @developit @thangngoc89 )
There was a problem hiding this comment.
Only show live URL on first render is more than enough for me. And I really hate any watcher that clear my terminal output
There was a problem hiding this comment.
I'm good with that format. I believe the "compiled successfully" bit can be done as the completion message of ProgressBarPlugin if it isn't already.
There was a problem hiding this comment.
It is now kinda different with @reznord's changes. Basically we would now show address only for successful builds and clear console after each build (IMHO that's much nicer).
| }; | ||
|
|
||
| const normalizeName = p => p.substr(p.lastIndexOf('!') + 1); | ||
| const stripBabelLoaderPrefix = log => log.replace(/@?\s*(\.\/~\/babel-loader\/lib\?{[\s\S]*?}!)/g, ''); |
There was a problem hiding this comment.
I have a boatload more of these transforms we can add, I'll get clearance to release them shortly.
There was a problem hiding this comment.
Would love to see those boatload of transforms @developit !
| let first = true; | ||
|
|
||
| compiler.plugin('done', stats => { | ||
| if (first) { |
There was a problem hiding this comment.
Removed this since it is better to clear off the console when there is an error and show the network interface when build is successful (every time)
|
@thangngoc89 @lukeed @developit this is good for your review !! |
|
Wohoo !! Here we go !! |
+1000 to DX
preact buildbefore:preact buildafter:preact watchbefore:preact watchafter:Changes:
stats.toJSON()acceptsoptionswhich could be 'errors-only' (like inwebpack.config.js)babel-loaderquery stripping (placed byasync-component-loader) to be more precise & maintanable (= renamed it 😆 )