Only remove prop types in a production build. #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable 'babel-plugin-transform-react-remove-prop-types' plugin during a development build. Some libraries expect prop types to be available during a development build.
reznord
reviewed
Jul 25, 2017
Member
reznord
left a comment
reznord
left a comment
There was a problem hiding this comment.
LGTM!
But not really sure why a library requires prop-types in a development build.
Author
|
@reznord I am not sure I fully understand how they are used, but it is a part of the AutoControlledComponent validation logic here. I don't fully understand it, and perhaps it is only useful when are you developing a component for Semantic-UI-React. I recently switched from react to preact, which is when the error started, so I decided to submit a PR. |
thangngoc89
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable 'babel-plugin-transform-react-remove-prop-types'
plugin during a development build. Some libraries
expect prop types to be available during a development
build.
Semantic UI React uses prop types during development
for validation. Issue 1869 has some additional context.