Skip to content

Conversation

@reznord
Copy link
Member

@reznord reznord commented Jul 30, 2017

Now you can do HTTPS=true npm start for starting the development server using https.

We can avoid that serious regression of flags in

npm start -- -- --https

Fixes #242

@reznord reznord self-assigned this Jul 30, 2017
@reznord reznord requested a review from lukeed July 30, 2017 04:57
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually do anything except print https:// to the console.

You'll need to update the webpack-client-config and probably watch command.

I may be missing others.

@reznord
Copy link
Member Author

reznord commented Jul 30, 2017

True! Forgot that part in the first time I committed. (Completing it now)

@reznord
Copy link
Member Author

reznord commented Jul 30, 2017

You'll need to update the webpack-client-config and probably watch command

We just need to change it in the watch.js file. Since from there we will pass down the config to the webpack-client-config

@reznord reznord merged commit 555d62d into master Jul 30, 2017
@prateekbh prateekbh deleted the watch-env-https branch July 30, 2017 06:13
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late review but looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants