Skip to content

Add missing dependencies - extract-text-webpack-plugin, chalk #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thangngoc89 merged 1 commit into from
Aug 11, 2017
Merged

Add missing dependencies - extract-text-webpack-plugin, chalk #306

thangngoc89 merged 1 commit into from
Aug 11, 2017

Conversation

@anantoghosh
Copy link
Contributor

@anantoghosh anantoghosh commented Aug 11, 2017

extract-text-webpack-plugin is now used instead of @webpack-blocks/extract-text2.
Also added missing chalk dependency.
Resolves #214

reznord
reznord approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@reznord reznord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anantoghosh anantoghosh reopened this Aug 11, 2017
@thangngoc89 thangngoc89 merged commit d7e0949 into preactjs:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reznord reznord reznord approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anantoghosh @reznord @thangngoc89