Edge case fix for prerender errors #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
requested review from
hassanbazzi,
lukeed,
reznord,
rkostrzewski and
thangngoc89
Member
|
Sorry, I looked thru this but forgot to mark Approve /facepalm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds error and node_modules lookup handling to prerender exception hook. As it turns out, #310 was actually a legit error:
@vimeo/playerandheadroom.jsboth try to accesswindow.xxon import, so they can't be imported in an SSR context at all. That was all going as planned, but the nice error handler we have for SSR was bailing because it generated an incorrect sourcemap filename. I've added some (possibly non-windows-friendly?) edge case handling to the filename generation, basically implementing rudimentary support for webpack's~/foolookup style to point those atnode_modules/foo.