Fix linting errors in templates. #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
commented
Aug 17, 2017
| import { Link } from 'preact-router/match'; | ||
| import style from './style'; | ||
|
|
||
| // eslint-disable-next-line |
Member
Author
There was a problem hiding this comment.
Added this line because eslint throws warnings for this.
As of now we are using eslint-config-synacor. Once we shift to eslint-preact-preset, we can remove these comments.
Contributor
Member
Author
There was a problem hiding this comment.
I was talking to @developit regarding this, he said he will soon add one. But I took care of the comment in another PR (up-coming). Added an extra set of rules to the eslintConfig
Member
Author
|
Closing this PR since now we are taking a whole different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the lint issues in templates (demos).