Skip to content

Conversation

@iiegor
Copy link
Contributor

@iiegor iiegor commented May 21, 2017

No description provided.

Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually use the CSS Modules approach -- does this work? I thought you could only do styles.active if there was a top-level .active rule in the stylesheet.

@iiegor
Copy link
Contributor Author

iiegor commented May 21, 2017

@lukeed Yep, it's working 😄 . The rule doesn't necessarily have be a top-level declaration to be used.

Details {"header":"header__2MqSo","active":"active__27Q54"}

Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid ~

@maximeborges
Copy link

maximeborges commented May 22, 2017

It doesn't work for me...
image

Edit: oh stupid me, i forgot to remove the quotes. It's perfect now ;-)

@developit
Copy link
Member

developit commented May 25, 2017

^ hehe

Thanks for this - must have been something I botched when porting over the demo from preact-boilerplate. I had originally migrated it to CSS without modules.

@developit developit merged commit d4fafce into preactjs:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants