initialize new projects with git init if git present

[fivetanley]

fixes #28
i may have also extracted that trimLeft functionality

[rkostrzewski]

I would add several more patterns to gitignore:

• ignoring logs:

*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

• ignoring coverage (preact-cli will be using jest AFAIK which uses istanbul)

coverage

The default gitignore for node might have some more goodies but frankly I haven't seen half of those files in any node project.

[lukeed]

^^ With *.log in place, no need for these:

npm-debug.log*
yarn-debug.log*
yarn-error.log*

[rkostrzewski]

I remember npm generating timestamps in log file names but it doesn't do so anymore (at least I don't remember how it is done) so probably they are not needed. :)

[rkostrzewski]

which.sync throws an error if command is not found according to the docs. Is the exception swallowed?

[developit]

This should be using the async version of which. Here's how:

import promisify from 'es6-promisify';

// ...

async function initializeVersionControl(target) {
  let git;
  try {
    git = await promisify(which)('git');
  }
  catch (err) {}
  if (!git) {
    // ... etc
  }
}

[fivetanley]

Why does this have to be async? It would throw in either case when using async/await.

[developit]

Just to avoid blocking (nothing else is blocking in the CLI).

[developit]

heh - I am wondering if this will spam me with notifications 😆

[reznord]

of dear !! That sure will. Good luck with that !!

[developit]

Overall this is great! Thanks for doing all the work, haha.

Only thing I'm keen to add to this aside from the little sync fix would be a git option that defaults to true, so someone can do preact create --no-git to avoid initializing a repo if they wish. I'm happy to add that after merging if it's not of interest :)

[lukeed]

Looks good to me! I would like to see a which abstraction that handles its own error case -- especially now that we have conditional Yarn usage.

I can add this in post-merge if needed.

[developit]

@lukeed agreed, it would be nice to have commandExists('yarn') that just returns a Boolean without the try/catch.

[rkostrzewski]

@developit @lukeed it's here - https://github.com/developit/preact-cli/pull/31/files#diff-3d03cf8df0979b4050f3a105cfd861c5R168 .
We can do this after merges.

[developit]

wow I even subconsciously stole the name.

One thought I had regarding the original topic here - what do we think of actually using git to clone starter projects? I believe vue-cli does this. There's just a github org for the templates, and init just clones them and does the installation. I normally try to avoid requiring git (not sure why), but the huge advantage would be that new templates can be released independent of the CLI. Also, anyone could then run preact create git://foo and start from their own template.

Thoughts? I think they were using a module that handled like 90% of the work too.

[developit]

I think this makes more sense to be paired up with #56 as a minor or even major.