feature: preact list #384
Merged
feature: preact list #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
lukeed
previously requested changes
Sep 26, 2017
Member
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
Please use unfetch or isomorphic-unfetch instead of axios. No reason to require another dependency.
Member
Author
I didn't use Re /cc @lukeed Edit: I was being an idiot while working on this, my bad. 😅 |
Member
|
heh - streams! |
reznord
dismissed
lukeed’s stale review
ayee, removed axios and used isomorphic-unfetch
lukeed
approved these changes
Sep 26, 2017
developit
added a commit
that referenced
this pull request
Oct 11, 2017
* master: (166 commits) Use `publicPath` for SW & Manifest paths (#323) Purge `examples` dir (#393) Update Readme (#383) Add `preact list` command (#384) linters are dumb inject / replace strings in extracted contents adding flag to disable service worker Convert `css-loader` options to an Object (#349) remove `offline-plugin` (unused) remove `mkdirp` (unused) remove `less` dependencies fix linter move `htmlPlugin` to `render-html-plugin.js` install `css|postcss|style-loader` & regen `yarn.lock` remove `chunk.modules` deprecation notice rewrite server’s `webpack.config` without blocks rewrite client’s `webpack.config` without blocks install `webpack-merge` rewrite base `webpack.config` w/o blocks light refactor ... # Conflicts: # src/lib/webpack/webpack-base-config.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New command to the CLI:
preact listNow that we have moved to custom templates, it is better to add a CLI command which will list out the official repos.
Edit: It fetches the list of repos from the URL
https://api.github.com/users/preactjs-templates/repos.