Copy Media files without Corruption #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don’t need to remember them for ensuing value injections
reznord
approved these changes
Oct 12, 2017
Member
reznord
left a comment
reznord
left a comment
There was a problem hiding this comment.
Yaaaay \o/ back to our normal size 😎 (144KB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
values-injectionPR (#353), I forgot to ignore all media files. Because of that, thesrc/assets/*contents were corrupted. This resulted in +100KB precache size, all of which was useless.Thanks for @reznord for pointing out the jump in bytes.
There's probably a better way to do this (via read/write streams?) but this should work for most cases.