Skip to content

Enable PostCSS SourceMaps #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reznord merged 1 commit into from
Oct 16, 2017
Merged

Enable PostCSS SourceMaps #404

reznord merged 1 commit into from
Oct 16, 2017

Conversation

@lukeed
Copy link
Member

@lukeed lukeed commented Oct 16, 2017

The move to [email protected] changed the sourceMap behavior.

In [email protected], the maps from preceding loaders (eg, css, sass, less) would still be kept. But as @timarney pointed out, 2.0 changed that behavior. The postcss-loader now states:

If a previous loader like e.g sass-loader is applied and its sourceMap option is set, but the sourceMap option in postcss-loader is omitted, previous source maps will be discarded by postcss-loader entirely.

Closes #403

reznord
reznord approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@reznord reznord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@reznord reznord merged commit 96e097b into master Oct 16, 2017
@reznord reznord deleted the fix-postcss branch October 16, 2017 19:24
@lukeed lukeed mentioned this pull request Oct 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reznord reznord reznord approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukeed @reznord