Skip to content

Allow PostCSS to sourceMap in Dev mode #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reznord merged 1 commit into from
Oct 20, 2017
Merged

Allow PostCSS to sourceMap in Dev mode #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/webpack/webpack-base-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function (env) {
{
loader: 'postcss-loader',
options: {
sourceMap: isProd,
sourceMap: true,
Copy link
Member

@reznord reznord Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we leave this in the user land whether to use sourceMaps in production or not?

Copy link
Member

@reznord reznord Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with both the options tho

Copy link
Member Author

@lukeed lukeed Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't production. This just always allows PostCSS to accept source maps. Whether or not source maps are created is determined by the (css|sass|stylus|less)-loaders.

This can still be overridden in Userland, if wanted, but there'd be no point.

Development sourcemaps don't work with out this.

plugins: [autoprefixer({ browsers })]
}
}
Expand All @@ -167,7 +167,7 @@ export default function (env) {
{
loader: 'postcss-loader',
options: {
sourceMap: isProd,
sourceMap: true,
plugins: [autoprefixer({ browsers })]
}
}
Expand Down