Skip to content

Conversation

@lukeed
Copy link
Member

@lukeed lukeed commented Jan 12, 2018

What kind of change does this PR introduce?

Fixes #459

Did you add tests for your changes?

N/A

Summary

Apparently, since October 2017, an underlying dependency has had an incompatibility with Webpack's ModuleConcatenationPlugin. Because of this, all files and chunks were producing the same [hash] and [chunkhash] values.

Before removing, I tried adjusting the output patterns, but that didn't change anything.

Luckily, it seems as though we weren't actually using this plugin in the way it was intended, so simply removing it worked.

We're now relying on Webpack's own hashing algorithm, which is probably a safe(r) bet since that's one of its first-class priorities.


@developit This will have to go out ASAP since everyone is producing repetitive builds. I suspect this is also playing a role in the SW issues.

@prateekbh
Copy link
Member

doesn't webpack rely on -p/NODE.ENV===production flag to add the hashes?

@lukeed
Copy link
Member Author

lukeed commented Jan 13, 2018

Yes, but we only care about preact build since that's the only time hashing is added to files. And build flags a production build.

(The DevServer is in-memory, no files added to disk.)

@developit developit merged commit bc0c665 into master Jan 13, 2018
@lukeed lukeed deleted the fix/hashing branch January 13, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants