[FIX] Non-Unique Filename Hashing #460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #459
Did you add tests for your changes?
N/A
Summary
Apparently, since October 2017, an underlying dependency has had an incompatibility with Webpack's
ModuleConcatenationPlugin. Because of this, all files and chunks were producing the same[hash]and[chunkhash]values.Luckily, it seems as though we weren't actually using this plugin in the way it was intended, so simply removing it worked.
We're now relying on Webpack's own hashing algorithm, which is probably a safe(r) bet since that's one of its first-class priorities.
@developit This will have to go out ASAP since everyone is producing repetitive builds. I suspect this is also playing a role in the SW issues.