no service worker is built if flag is passed #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
requested changes
Feb 16, 2018
Member
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
Can we revert the imports? 🙏 Otherwise looks good!
prateekbh
force-pushed
the
noSWForFlagFix
branch
from
84414a7 to
b45c8ec
Compare
prateekbh
force-pushed
the
noSWForFlagFix
branch
from
b45c8ec to
f3e785a
Compare
Member
Author
|
@lukeed done |
lukeed
requested changes
Feb 19, 2018
Member
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
My bad, must have missed the first time 🙈
| /\.map$/, | ||
| /push-manifest\.json$/, | ||
| /.DS_Store/, | ||
| /\.git/ |
Member
|
I forgot I can do it too, will push the final fix real quick~ |
lukeed
approved these changes
Feb 19, 2018
Member
|
Thanks @prateekbh 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
Summary
After this PR
--no-service-workerflag will not even build the service worker hence lesser confusionDoes this PR introduce a breaking change?
Nope
Closes #420