decorators must come before class-properties #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy#note-order-of-plugins-matters the decorators plugin must be loaded before the class-properties one
reznord
approved these changes
Feb 19, 2018
Member
|
shouldn't effect the travis because of this order! So going to merge this 😄 |
Member
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
Summary
as per https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy#note-order-of-plugins-matters the
babel-plugin-transform-decorators-legacyplugin should come beforebabel-plugin-transform-class-propertieswe use
react-trackingand it's decorators broke due to the incorrect order.Does this PR introduce a breaking change?
no
Other information
N/A