remove script-ext-html-webpack-plugin and add script loading option #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Only thing with this is that it'll leave user-added scripts unmodified. Different from how it works today, but probably the right way to go 👍 |
developit
approved these changes
Jan 4, 2019
Member
|
fuck, I didn't mean to do that |
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
No
Summary
After this fix #127 script tag is added by template instead of using
script-ext-html-webpack-plugin. Also thedefaultAttributeis not used as it is hardcoded in template.I propose adding a new option in
html-webpack-plugincalledscriptLoadingand it is configurable.Does this PR introduce a breaking change?
NO