Fix async components diffing #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to define the class `constructor`, else async components are recreated everytime the parent rerenders. Technical detail: if not defined on the `Async` class, the property `constructor` is inherited from `Component`, and preact does not find the actual `Async` constructor in `buildComponentFromVNode`, so it doesn't find the component owner, so the component is recreated.
Member
|
hah! I knew that would catch up with me. Thanks for the PR and great explanation. |
developit
approved these changes
May 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to define the class
constructor, else async components are recreated everytime the parent rerenders.Technical details: if not defined on the
Asyncclass, the propertyconstructoris inherited fromComponent, and preact does not find the actualAsyncconstructor inbuildComponentFromVNode, so it doesn't find the component owner, so the component is recreated.I made a gist if you want to reproduce 😄 https://gist.github.com/BenoitZugmeyer/67b44e172a44d013290d25b62052f207