Skip to content

Using same version of preact for pre-rendering #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 5 commits into from
May 28, 2019
Merged

Using same version of preact for pre-rendering #803

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1439a3c
using same version of preact for pre-rendering
prateekbh May 20, 2019
c03d22d
adding explainer
prateekbh May 20, 2019
5482228
uses preact and preact-render-to-string from user land
prateekbh May 20, 2019
639fa08
use preact and render to string from user land always
prateekbh May 21, 2019
6254c6f
separate variables
ForsakenHarmony May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/cli/lib/lib/webpack/prerender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { red, yellow } = require('kleur');
const { resolve } = require('path');
const { readFileSync } = require('fs');
const { readFileSync, existsSync } = require('fs');
const stackTrace = require('stack-trace');
const { SourceMapConsumer } = require('source-map');

Expand All @@ -24,10 +24,15 @@ module.exports = function(env, params) {
);
return '';
}

let preact = require('preact'),
renderToString = require('preact-render-to-string');

const { cwd } = env;
const preactPath = require.resolve(`${cwd}/node_modules/preact`);
const renderToStringPath = require.resolve(
`${cwd}/node_modules/preact-render-to-string`
);
let preact = require(preactPath),
renderToString = require(existsSync(renderToStringPath)
? renderToStringPath
: 'preact-render-to-string');
return renderToString(preact.h(app, { ...params, url }));
} catch (err) {
let stack = stackTrace.parse(err).filter(s => s.getFileName() === entry)[0];
Expand Down
3 changes: 3 additions & 0 deletions packages/cli/lib/lib/webpack/webpack-server-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ function serverConfig(env) {
chunkFilename: '[name].chunk.[chunkhash:5].js',
libraryTarget: 'commonjs2',
},
externals: {
preact: 'preact',
},
target: 'node',
resolveLoader: {
alias: {
Expand Down