Skip to content

fix: Build returns non-zero exit code for failed builds. #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
developit merged 1 commit into from
Jun 7, 2017
Merged

fix: Build returns non-zero exit code for failed builds. #86

developit merged 1 commit into from
Jun 7, 2017

Conversation

@rkostrzewski
Copy link
Collaborator

@rkostrzewski rkostrzewski commented Jun 1, 2017 •
edited
Loading

This time I'm bringing even more conflicts on other branches 😭 Fixes #61

@rkostrzewski rkostrzewski changed the title fix: Build returns non-zero exit code for failed builds. Fixes #61 fix: Build returns non-zero exit code for failed builds. Jun 1, 2017
@developit
Copy link
Member

developit commented Jun 7, 2017

Looks good to me. Maybe one more set of eyes?

@developit developit requested a review from lukeed June 7, 2017 02:53
lukeed
lukeed approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work 👍 Don't think we need to include any additional stats details either.

@developit developit merged commit 8539f42 into master Jun 7, 2017
@developit developit deleted the fix/build-error-exit-code branch June 7, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developit developit developit approved these changes

@lukeed lukeed lukeed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rkostrzewski @developit @lukeed