Skip to content

Conversation

@thangngoc89
Copy link
Collaborator

This is to prevent cryptic stack trace like this

Uncaught TypeError: Cannot read property '_renderedComponent' of undefined
    at visitNonCompositeChildren (eval at ./cli/node_modules/preact/devtools.js (app.925b01a….js:912), <anonymous>:209:16)
    at Object.componentUpdated (eval at ./cli/node_modules/preact/devtools.js (app.925b01a….js:912), <anonymous>:151:4)
    at Object.preact.options.afterUpdate (eval at ./cli/node_modules/preact/devtools.js (app.925b01a….js:912), <anonymous>:237:11)
    at k (eval at ./cli/node_modules/preact/dist/preact.min.js (app.925b01a….js:920), <anonymous>:159:122)
    at i (eval at ./cli/node_modules/preact/dist/preact.min.js (app.925b01a….js:920), <anonymous>:28:16)

@developit developit merged commit 61bacf9 into preactjs:master Jun 7, 2017
@thangngoc89 thangngoc89 deleted the patch-1 branch June 7, 2017 12:52
@oren
Copy link

oren commented Jun 8, 2017

Does it mean I will know where the error is actually coming from? That's awesome

@thangngoc89
Copy link
Collaborator Author

@oren Not actually. Just the last two lines in the above error (which is from preact's source)

at k (eval at ./cli/node_modules/preact/dist/preact.min.js (app.925b01a….js:920), <anonymous>:159:122)
    at i (eval at ./cli/node_modules/preact/dist/preact.min.js (app.925b01a….js:920), <anonymous>:28:16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants