-
-
Notifications
You must be signed in to change notification settings - Fork 372
Inline CSS fixes #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline CSS fixes #908
Conversation
|
Ahhh problem! |
wdym? |
|
Like deploy to surge and redirect * to / |
|
Oh you're talking about the backend always serving |
|
yep, in that case all routes will download an extra |
|
// @developit: ^ request for additional stylesheets options in critters |
To be merged after: GoogleChromeLabs/critters#45
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
Updated the existing tests
Summary
Critters only inlines the css from the css files actually present in the html.
This was the reason why home page's css was never inlined on http://cli-demo-next.preactjs.com
This PR adds route's css as well as bundle css
Does this PR introduce a breaking change?
No