Bug: Portals aren't unmounting #501

Activity

1. dbergey commented on Sep 24, 2018

   

   dbergey

   on Sep 24, 2018

   More actions

   Including this file:

   import { createElement as h } from 'react';
   import { unmountComponentAtNode, unstable_renderSubtreeIntoContainer as renderSubtreeIntoContainer } from 'react-dom';
   
   class Portal {
   	componentWillUnmount() {
   		unmountComponentAtNode(this.props.container);
   	}
   	componentDidMount() {
   		renderSubtreeIntoContainer(this, this.props.vnode, this.props.container);
   	}
   	render() {
   		// render nothing at original location
   	}
   }
   
   export function createPortal(vnode, container) {
   	return h(Portal, { vnode, container });
   }
   

   and using the exported createPortal instead of the one in preact-compat solved it for me (as suggested in the 'possible solution' above).

   👍React with 👍1Reacted by garkin