Always infer debug mode from flag#468
Merged
marvinhagemeister merged 3 commits intomainfrom Mar 6, 2023
Merged
Conversation
4cd7293 to
e1cd00c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't exactly reconstruct why I accidentally uploaded a debug build for chrome yesterday when cutting a new version (see #467 ). My assumption is that I ran the
run:chromecommand which builds a debug extension and loads it into a fresh chrome instance. I typically always use that just before publishing to make a final smoke test check. Normally, I run thebuild:chromecommand once that's done but it looks like I forgot that yesterday. That's very likely what happened yesterday.To prevent such accidents in the future this PR makes a couple of changes:
-debugsuffix to zipped debug extensionsprocess.env.DEBUG