Feature: add commit filtering to the profiler#474
Merged
marvinhagemeister merged 2 commits intopreactjs:mainfrom Apr 1, 2023
Merged
Feature: add commit filtering to the profiler#474marvinhagemeister merged 2 commits intopreactjs:mainfrom
marvinhagemeister merged 2 commits intopreactjs:mainfrom
Conversation
jpnelson
commented
Apr 1, 2023
Contributor
Author
There was a problem hiding this comment.
The diff here is a little weird, but the main change to this file is extracting FilterPopup from it
marvinhagemeister
approved these changes
Apr 1, 2023
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Love this! This is such a great idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This surely needs some cleanup, but I wanted to put this out there as a feature suggestion! For our use cases, the profiler is very helpful, but is pretty hard to use when we have multiple hundreds of commits. This adds a filter to it, so you can specify which durations you're interested in looking at:
There's an empty state when you hide all of the commits, so it's clear what's going on:
Some edge cases handled:
Implementation details
Future work
It would be great to be able to filter additional things in or out of the commit timeline in the future so commits can be further searched. Maybe by the count of nodes in the commit?