Repository navigation
Preact and custom elements #405
Description
Hello,
I have a native custom element, lets call it <custom-video-player>.
It handles its own children. The children can be a <video> or an <image> for example.
Unfortunately preact clobbers the child dom that I create in my createdCallback and the entire component breaks.
Is there an option I can pass in to make preact accept the component as it is and not traverse its children?
I am guessing this is related/identical to #39
Reacted by Magnus Ferm and Tom Conroy
Activity
developit commentedon Nov 15, 2016
This is fixed in version 7.
npm I preact@beta.Also I believe it only affects polyfilled custom Elements.
oskbor commentedon Nov 15, 2016
woho! that works very well for me 👍 thanks
developit commentedon Nov 15, 2016
Awesome, I really appreciate you opening this issue since I didn't have time to manually test this fix out myself. I was convinced it would work and I'm happy it does! Thanks @oskbor!!
tconroy commentedon May 13, 2017
Hi @oskbor -- I'm running into a similar issue you described (mine is #344). So my custom elements are rendering as-expected on initial page render, but when navigating to subsequent views (in a SPA etc), they stop updating.
They also maintain their own internal nodes, and after inspecting the nodes it seems like there contents have been wiped out. Seems like Preact is breaking the shadow dom for custom elements.
Wondering if you had to do anything in addition to get this working aside from just bumping preact version? I've tried the latest versions and still running into issues. :(
Any input much appreciated.
oskbor commentedon May 13, 2017