Merged
Conversation
🦋 Changeset detectedLatest commit: f46098d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: -688 B (-0.41%) Total Size: 166 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #882 (comment)
Problem
When a component with signal-bound props (e.g.
<div class={cls}>) was unmounted and later remounted via<Show>, the signal props stopped updating. The DOM element was stuck with the last value from before unmounting.Root Cause
In
createPropUpdater, the effect usedprops[prop] = valueto deduplicate DOM writes. This wrote a plain string back intovnode.props, clobbering the original Signal reference. On remount, the DIFF hook no longer detected a Signal in the props and skipped setting up reactive tracking.Fix
Replaced the
props[prop]-based deduplication with a locallastRenderedValuevariable. This avoids mutatingvnode.props, preserving the Signal reference across unmount/remount cycles.