Skip to content

Conversation

@nuba-io
Copy link

@nuba-io nuba-io commented Oct 10, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

doc MR: prebid/prebid.github.io#6295

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b9a4ba6

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:138:	getMediaTypeForImp	100.0%
total:								(statements)		92.2%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6c9d9f2

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:143:	getMediaTypeForImp	66.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:162:	getMediaTypeForBid	100.0%
total:								(statements)		87.5%

@bsardo bsardo added the adapter label Oct 16, 2025
@bsardo bsardo changed the title Nuba Bid Adapter: initial release New Adapter: Nuba Oct 28, 2025
@bsardo
Copy link
Collaborator

bsardo commented Oct 28, 2025

Hi @nuba-io, is this a white label solution? This looks very similar to the Compass adapter.

@nuba-io
Copy link
Author

nuba-io commented Nov 4, 2025

Hi @bsardo,
Yes, is a white label solution.
It may look similar to Compass, but it's a separate solution.

@nuba-io
Copy link
Author

nuba-io commented Nov 14, 2025

Hi, @bsardo @jney @minaguib @dlackty )
Do you have any other comments on PR?

@bsardo
Copy link
Collaborator

bsardo commented Nov 20, 2025

@nuba-io thanks for the response. Can you elaborate on why you're calling it a white label but also a separate solution? Prebid Server has strict guidelines that if an adapter is a white label, the aliasing feature should be used instead of copying an adapter. This significantly reduces review and maintenance time as it cuts the lines of code from 1k+ to ~20.

@nuba-io
Copy link
Author

nuba-io commented Nov 21, 2025

Hi, @bsardo
Thanks for raising this point — it’s a valid concern.
We’ve updated the PR to fully align with the white-label guidelines you mentioned. The implementation now uses the aliasing approach instead of duplicating the adapter, which keeps the code minimal and reduces the review and maintenance overhead.

If there’s anything else we should refine, happy to adjust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants