-
Notifications
You must be signed in to change notification settings - Fork 845
New Adapter: Nuba #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Adapter: Nuba #4565
Conversation
Code coverage summaryNote:
nubaRefer here for heat map coverage report |
Code coverage summaryNote:
nubaRefer here for heat map coverage report |
|
Hi @nuba-io, is this a white label solution? This looks very similar to the Compass adapter. |
|
Hi @bsardo, |
|
@nuba-io thanks for the response. Can you elaborate on why you're calling it a white label but also a separate solution? Prebid Server has strict guidelines that if an adapter is a white label, the aliasing feature should be used instead of copying an adapter. This significantly reduces review and maintenance time as it cuts the lines of code from 1k+ to ~20. |
|
Hi, @bsardo If there’s anything else we should refine, happy to adjust. |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
doc MR: prebid/prebid.github.io#6295