Skip to content

♻️ comply with new pandas index handling #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022
Merged

♻️ comply with new pandas index handling #37

merged 2 commits into from
Mar 18, 2022

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Mar 18, 2022

This PR solves issue #36

Note: I benchmarked .is_integer vs the current isinstance checking. My findings are that .is_integer is slightly slower, but this is a constant (minor) difference, meaning that just like for type checking the runtime does not deteriorate for longer index lengths.

image

@jvdd jvdd requested a review from jonasvdd March 18, 2022 12:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #37 (3826dd7) into main (05b252c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           6        6           
  Lines         389      389           
=======================================
  Hits          385      385           
  Misses          4        4           
Impacted Files Coverage Δ
plotly_resampler/figure_resampler.py 98.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b252c...3826dd7. Read the comment docs.

@jonasvdd
Copy link
Member

LGTM!

@jvdd jvdd merged commit c65390f into main Mar 18, 2022
@jvdd jvdd deleted the pandas_index branch May 1, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants