Skip to content

feat: Run tasks and shells through pixi_api instead of the pixi CLI - #186

Merged
haecker-felix merged 8 commits into
prefix-dev:mainfrom
haecker-felix:pixi_gui_run
Nov 2, 2026
Merged

haecker-felix merged 8 commits into
prefix-dev:mainfrom
haecker-felix:pixi_gui_run

Conversation

@haecker-felix

@haecker-felix haecker-felix commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

@haecker-felix
haecker-felix marked this pull request as ready for review November 2, 2026 07:54

@Hofer-Julian Hofer-Julian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only had one comment

let _ = WorkspaceContext::init(session, options)
.await
.map_err(|e| format_error_chain(&e))?;
.map_err(|e| format_error_chain(&miette::Report::new(e)))?;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think format_error_chain should instead be able to deal with any error implementing miette:Diagnostics

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh... Looks like the init() command was a leftover. It also returns error now instead of a plain string, which also removes the manual miette wrapping.

11212bf

@haecker-felix
haecker-felix merged commit 7901c5f into prefix-dev:main Nov 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants