Repository navigation
feat: Run tasks and shells through pixi_api instead of the pixi CLI - #186
Merged
Merged
Conversation
haecker-felix
force-pushed
the
pixi_gui_run
branch
from
October 27, 2026 10:35
0094a96 to
c8553ad
Compare
haecker-felix
force-pushed
the
pixi_gui_run
branch
from
November 2, 2026 07:54
7a25858 to
ddd375b
Compare
haecker-felix
marked this pull request as ready for review
November 2, 2026 07:54
Hofer-Julian
reviewed
Nov 2, 2026
Hofer-Julian
left a comment
Member
There was a problem hiding this comment.
Looks good, only had one comment
| let _ = WorkspaceContext::init(session, options) | ||
| .await | ||
| .map_err(|e| format_error_chain(&e))?; | ||
| .map_err(|e| format_error_chain(&miette::Report::new(e)))?; |
Member
There was a problem hiding this comment.
I think format_error_chain should instead be able to deal with any error implementing miette:Diagnostics
Collaborator
Author
There was a problem hiding this comment.
Ehh... Looks like the init() command was a leftover. It also returns error now instead of a plain string, which also removes the manual miette wrapping.
haecker-felix
force-pushed
the
pixi_gui_run
branch
from
November 2, 2026 08:43
e41ee52 to
11212bf
Compare
Hofer-Julian
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on prefix-dev/pixi#7354