Repository navigation
Conversation
pavelzw
marked this pull request as ready for review
October 28, 2026 13:03
pavelzw
enabled auto-merge (squash)
October 28, 2026 13:03
pavelzw
disabled auto-merge
October 28, 2026 13:04
6 tasks done
Collaborator
Author
|
superseded by #7388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pixi publish --to artifactory://<server>/<repository>only uses the host of the target URL:upload_to_artifactorytakes the last path segment as the repository name and then callsserver_url.set_path(""), dropping everything else.Artifactory instances that are served under a path prefix can therefore not be targeted. The most common case is JFrog Cloud, where repositories live below
https://<org>.jfrog.io/artifactory/. Withartifactory://org.jfrog.io/artifactory/my-repopixi currently PUTs tohttps://org.jfrog.io/my-repo/<subdir>/<file>, which JFrog Cloud answers with a 404.Fix
split_artifactory_url, which takes the last path segment as the repository and keeps the preceding path (with a trailing slash) as part of the server URL.rattler_uploadthen joins<repository>/<subdir>/<filename>onto it as before.artifactory://server/<repository>without a prefix keeps working unchanged.artifactory://server/<prefix>/<repository>form in the CLI help, the generated CLI docs and the docs extender.Note:
pixi upload artifactory --url https://org.jfrog.io/artifactory/ --channel my-repoalready works, since it takes the full server URL. This PR bringspixi publishin line with it.