Skip to content

fix(tasks): fix various bugs - #7434

Merged
Hofer-Julian merged 7 commits into
prefix-dev:mainfrom
lucascolley:fix-pixi-task-bugs
Nov 2, 2026
Merged

Hofer-Julian merged 7 commits into
prefix-dev:mainfrom
lucascolley:fix-pixi-task-bugs

Conversation

@lucascolley

Copy link
Copy Markdown
Member

Fixes pixi task bugs found while working on #7426 for #6707. Each fix is in its own commit:

  • pixi task list -e Bad_Name ignored the invalid name and listed every environment. The parse error is now reported, also with --json.
  • pixi task list --json ignored -e, so -e nope succeeded too. It now lists only the given environment and reports an unknown one.
  • pixi task remove hello --platform linux-64 reported a task from the base [tasks] as removed without changing anything. Removal now looks only at the tasks declared for that platform, through the new WorkspaceManifest::declares_task. The in-memory target is now keyed with PixiPlatform::as_target_selector, as the TOML document is, since TargetSelector::from gives a different key for subdir platforms like linux-64.
  • pixi task remove saved the manifest even when none of the tasks existed, so a read-only pixi.toml failed with a write error.
  • The pixi task add/alias success messages started aliases with ", ", printed env as Rust debug output and left out args, cwd and clean-env. Task's Display now renders the task exactly as it is written into the manifest. This is slightly more verbose for simple cases, but it seems worth it to me overall as it makes complex cases a lot more clear.
  • pixi task add n --platform linux-64 ... failed with "already exists" when n was in the base [tasks], so a task couldn't be overridden for a platform. Adding now uses the same check as removing.
  • The messages for tasks that pixi task remove can't find now follow the error style.
Before After
Added alias `al`: , depends-on = 'hello' Added alias `al`: [{ task = "hello" }]
Added task `p`: echo hi Added task `p`: "echo hi"
Added task `d`: echo, depends-on = [hello,e], description = "hi" Added task `d`: { cmd = "echo", depends-on = ["hello", "e"], description = "hi" }
Added task `e`: echo $A, env = {"A": TemplateString("1")} Added task `e`: { cmd = "echo $A", cwd = "sub", env = { A = "1" }, clean-env = true }
Task `{name}` does not exist for feature '{feature}' task '{name}' does not exist for feature '{feature}'
Task '{name}' does not exist on {platform} task '{name}' does not exist on '{platform}'

`pixi task list -e Bad_Name` dropped the name when it failed to parse
and listed every environment instead. The parse error is now reported,
also for `--json`.
`pixi task list --json` ignored `-e` and printed every environment, so
`-e nope` succeeded too. It now prints only the given environment, and
reports an unknown one.
`pixi task remove hello --platform linux-64` reported the task as
removed when `hello` was only in the base `[tasks]`, and left the
manifest unchanged. The existence checks looked at the tasks resolved
for the platform, which include the inherited ones. They now use the new
`WorkspaceManifest::declares_task`, which looks only at the platform's
own target.

That lookup keys the target with `PixiPlatform::as_target_selector`,
as the TOML document does. `TargetSelector::from` gives a different key
for a subdir platform such as `linux-64` than the one the manifest
parser produces, so `add_task` and `remove_task` now use it too.
`pixi task remove` saved the manifest even when none of the named tasks
existed, so with a read-only `pixi.toml` it failed with a write error on
top of the "does not exist" messages.
The `pixi task add` and `pixi task alias` messages show the task through
its `Display`, which started an alias with ", ", printed `env` as Rust
debug output, and left out `args`, `cwd` and `clean-env`. `Display` now
renders the task with the same conversion that writes it into the
manifest, so the message matches the file.

| Before | After |
|---|---|
| ``Added alias `al`: , depends-on = 'hello'`` | ``Added alias `al`: [{ task = "hello" }]`` |
| ``Added task `p`: echo hi`` | ``Added task `p`: "echo hi"`` |
| ``Added task `d`: echo, depends-on = [hello,e], description = "hi"`` | ``Added task `d`: { cmd = "echo", depends-on = ["hello", "e"], description = "hi" }`` |
| ``Added task `e`: echo $A, env = {"A": TemplateString("1")}`` | ``Added task `e`: { cmd = "echo $A", cwd = "sub", env = { A = "1" }, clean-env = true }`` |
`pixi task add n --platform linux-64 ...` failed with "task 'n' already
exists" when `n` was in the base `[tasks]`, because the check included
the tasks the platform inherits. Writing the override under
`[target.linux-64.tasks]` by hand works, and removing with `--platform`
now looks only at the platform's own tasks, so adding uses the same
check.
The messages for a task that `pixi task remove` can't find were
capitalised, quoted the name differently depending on the platform, and
styled names with terminal colours.

| Before | After |
|---|---|
| ``Task `{name}` does not exist for feature '{feature}'`` | task '{name}' does not exist for feature '{feature}' |
| Task '{name}' does not exist on {platform} | task '{name}' does not exist on '{platform}' |
@lucascolley lucascolley added bug Something isn't working area:tasks labels Nov 2, 2026

@Hofer-Julian Hofer-Julian left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how much more obvious both code and error messages are now!

@Hofer-Julian
Hofer-Julian enabled auto-merge (squash) November 2, 2026 16:04
@Hofer-Julian
Hofer-Julian merged commit adae25e into prefix-dev:main Nov 2, 2026
42 of 70 checks passed
tenzinplatter added a commit to greenroom-robotics/pixi that referenced this pull request Nov 10, 2026
* feat(lock): honor exclude-newer exemptions in satisfiability (prefix-dev#7247)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor(core): add `Cause` wrapper, type the lock-file load, write and prefix errors (prefix-dev#7314)

* feat(manifest): deprecate the top-level `exclude-newer` tables (prefix-dev#7248)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor(global): type the trampoline, install and completions errors (prefix-dev#7357)

* feat(global): use match spec exemptions in `exclude-newer` (prefix-dev#7249)

* docs: document exclude-newer exemptions (prefix-dev#7251)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor(global): type the global directory and conda-meta errors (prefix-dev#7359)

* chore(ci): Update cargo patches (prefix-dev#7361)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update GitHub Actions (prefix-dev#7362)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update Rust crate rstest to 0.28.0 (prefix-dev#7366)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update Rust crate lzma-rust2 to 0.23 (prefix-dev#7365)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: add `release` scope to automated release commit messages (prefix-dev#7360)

* chore: update rattler and rattler-build crates (prefix-dev#7267)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* chore(ci): Update rattler (prefix-dev#7317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(cli): add exclude-newer commands for workspaces and pixi global (prefix-dev#7356)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* chore(ci): Update uv to 0.0.92 (prefix-dev#7318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* chore(ci): Update Swatinem/rust-cache action to v2.9.3 (prefix-dev#7371)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: add Cargo.lock from pixi-build example (prefix-dev#7372)

* feat: add cutoffs to exclude-newer exemptions (prefix-dev#7363)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* chore(ci): Update uv to 0.0.96 (prefix-dev#7376)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* test: cover cache-name collision for zero-component versions (prefix-dev#7373)

* fix(publish): keep Artifactory context path when uploading (prefix-dev#7388)

* chore(ci): Upgrade Pixi dependencies (prefix-dev#7331)

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

* fix: keep PyPI releases without an upload time for exempted packages (prefix-dev#7374)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* feat(pixi_api): Expose run and shell (prefix-dev#7354)

* feat: per-index exclude-newer for PyPI extra indexes (prefix-dev#7382)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* chore: revamp contributor docs and PR template (prefix-dev#7323)

Co-authored-by: Julian Hofer <julianhofer@gnome.org>
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* feat: add nanobind-dev and python3-typing-extensions as in rosdistro (prefix-dev#7379)

* fix: reuse the build backend environment with a relative exclude-newer (prefix-dev#7384)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* feat(info): show effective TLS root certificates (prefix-dev#7336)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor(global): type the global manifest errors (prefix-dev#7358)

* fix(cli): honour colour settings in help and argument errors (prefix-dev#7396)

* ci: enforce vouching for pull requests (prefix-dev#7390)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor(global): type the project discovery and list errors (prefix-dev#7397)

* refactor(global): type the install and sync errors (prefix-dev#7399)

* feat(pixi-build-backend): let backends generate multi-output recipes (prefix-dev#7381)

* docs: adapt vouch request (prefix-dev#7403)

* docs: clarify how to ping us (prefix-dev#7404)

* refactor(pixi_api): type the shell errors (prefix-dev#7407)

* fix(cache): use xxh3 for all on-disk cache names (prefix-dev#7408)

* feat: add sha256 to workspace explicit export (prefix-dev#7185)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* feat(publish): no `publish = true` required if explicit `--path` option is given (prefix-dev#7355)

* fix: skip system CA store for pypi mapping middleware client (prefix-dev#6936)

Co-authored-by: Bas Zalmstra <4995967+baszalmstra@users.noreply.github.com>

* fix(config)!: make a config file that fails to parse a hard error (prefix-dev#7409)

* refactor(api): type the init errors (prefix-dev#7410)

* chore(pixi-build-ros): add tqdm (prefix-dev#7307)

* fix(global): remove packages with custom exposed names (prefix-dev#7313)

* fix(pixi-build-ros): support cross-compiling `ament_python` packages (prefix-dev#7345)

* chore: fix missing `InitError::Config` (prefix-dev#7413)

* chore: remove duplicate `InitError::Config` (prefix-dev#7415)

* refactor(api): type the workspace setter errors (prefix-dev#7414)

* docs(setup-pixi): Mention setup-pixi being pre-v1 (prefix-dev#7419)

* docs(setup-pixi): Document configuration input and bump to v0.11.3 (prefix-dev#7421)

* docs: Fix PowerShell custom shell example for GitHub Actions (prefix-dev#7423)

* docs(setup-pixi): Fix instructions for enabling debug logging (prefix-dev#7422)

* refactor(api): type the add errors (prefix-dev#7416)

* ci: require approval before publishing releases (prefix-dev#6766)

* refactor(api): type the task errors (prefix-dev#7426)

* chore: add AGENTS.md (prefix-dev#7412)

* fix(tasks): fix various bugs (prefix-dev#7434)

* feat(pixi_api): add GlobalContext with pixi global list (prefix-dev#7387)

* chore(lock): never install the conda prefix in the PyPI satisfiability check (prefix-dev#7427)

* fix(exclude-newer): resolve relative cutoffs once per workspace load (prefix-dev#7435)

* feat(config): add `exclude-newer` (prefix-dev#7385)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* feat(publish): build with the exclude-newer of the workspace (prefix-dev#7386)

* chore(ci): Update GitHub Actions (prefix-dev#7440)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update cargo patches (prefix-dev#7439)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update Rust crate parking_lot to 0.13.0 (prefix-dev#7444)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): bump version to v0.84.0 (prefix-dev#7446)

* feat: integrate conda-pypi wheels using released rattler (prefix-dev#7392)

* chore(ci): Update Rust crate lzma-rust2 to 0.24 (prefix-dev#7443)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ci): Update Rust crate tokio to v1.54.1 (prefix-dev#7445)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(cli): fix multiple reporters problems (prefix-dev#7429)

* chore(ci): Update uv to 0.0.98 (prefix-dev#7442)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* fix(export): honour `--ignore-source-errors` in conda explicit export (prefix-dev#7425)

* feat(pixi-build-ros): rtklib (prefix-dev#7461)

* chore(ci): Upgrade Pixi dependencies (prefix-dev#7468)

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

* chore: adapt to new `exclude-newer` design (prefix-dev#7470)

* ci: publish dev release builds of main via octo-sts (prefix-dev#7193)

* fix(run): detect only the installed environment's host (prefix-dev#7462)

* fix(reporters): hide the repodata bar on clear with downloads in flight (prefix-dev#7459)

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

* refactor(pixi_api): type the run errors (prefix-dev#7463)

* chore(release): bump version to v0.84.1 (prefix-dev#7472)

* feat(pixi_api): add global install and uninstall to GlobalContext (prefix-dev#7447)

* feat: derive PyPI purls for the conda-pypi channel (prefix-dev#7477)

* feat(pixi-build-mojo): add explicit CPU and AMD GPU variants (prefix-dev#7431)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* docs: Add CPU and AMD GPU Mojo package tutorial (prefix-dev#7432)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* refactor: keep miette reports out of library crates (prefix-dev#7465)

* docs: Added documentation for publishing to Artifactory (prefix-dev#7481)

* ci: publish nightly releases from CI build artifacts (prefix-dev#7474)

* ci: cross-compile the linux aarch64 build with cargo-zigbuild (prefix-dev#7482)

* feat: add `pixi self-update --nightly` (prefix-dev#7473)

* fix(cli): reject several exclude-newer exemption specs of one package (prefix-dev#7467)

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

* docs: add a virtual package detector example (prefix-dev#7428)

* chore(ci): Update cargo patches (prefix-dev#7495)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Co-authored-by: prefix-dev-pixi-upgrades[bot] <326415524+prefix-dev-pixi-upgrades[bot]@users.noreply.github.com>
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
Co-authored-by: Felix Häcker <felix@prefix.dev>
Co-authored-by: Bas Zalmstra <4995967+baszalmstra@users.noreply.github.com>
Co-authored-by: Julian Hofer <julianhofer@gnome.org>
Co-authored-by: Ezra Brooks <ezra@brooks.cx>
Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
Co-authored-by: Zhaoqi Xu <lzy00419@outlook.com>
Co-authored-by: Yannik Tausch <dev@ytausch.de>
Co-authored-by: NichMor <nmorkotilo@gmail.com>
Co-authored-by: lldash <michiel.jacobs@vito.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tasks bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants