tests: verify license, test, and recipe files are included in package…#2234
Open
Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Open
tests: verify license, test, and recipe files are included in package…#2234Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Author
|
@wolfv can you review this when you have time please? |
wolfv
reviewed
Mar 6, 2026
| /// Helper to extract a .tar.bz2 package and return the extraction directory. | ||
| fn extract_package(package_path: &Path) -> tempfile::TempDir { | ||
| let extract_dir = tempfile::tempdir().expect("failed to create temp dir for extraction"); | ||
| let file = std::fs::File::open(package_path).expect("failed to open package"); |
Member
There was a problem hiding this comment.
You should use fs::File (that is fs_err as imported above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates integration tests for
rattler_build_packageto fully verify that additional files are correctly included in package archives.These changes address previous TODOs and improve confidence that files are packaged correctly without altering build behavior.