Skip to content

Force UTF-8 encoding; do not strip out UTF-8 chars.#106

Merged
grosser merged 2 commits into
premailer:masterfrom
tablecheck:master
Dec 1, 2019
Merged

Force UTF-8 encoding; do not strip out UTF-8 chars.#106
grosser merged 2 commits into
premailer:masterfrom
tablecheck:master

Conversation

@johnnyshields

@johnnyshields johnnyshields commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

The line changed was causing UTF-8 chars to be stripped out in the CSS parsing. UTF-8 chars are needed for 'font-family' of Asian fonts. Not sure why binary encoding was used here previously.

font-family: "Helvetica Neue","Microsoft YaHei UI","Microsoft YaHei New","Microsoft YaHei","微软雅黑","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji",sans-serif,system-ui;

The line changed was causing UTF-8 chars to be stripped out in the CSS parsing. UTF-8 chars are needed for 'font-family' of Asian fonts. Not sure why binary encoding was used here previously.
@johnnyshields johnnyshields changed the title Force UTF-8 encoding Force UTF-8 encoding; do not strip out UTF=8 chars. Dec 1, 2019
@johnnyshields johnnyshields changed the title Force UTF-8 encoding; do not strip out UTF=8 chars. Force UTF-8 encoding; do not strip out UTF-8 chars. Dec 1, 2019
@grosser
grosser merged commit a477d66 into premailer:master Dec 1, 2019
@grosser

grosser commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

1.7.1

@johnnyshields

Copy link
Copy Markdown
Contributor Author

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants