-
Notifications
You must be signed in to change notification settings - Fork 5.5k
build(deps): Bump CUDA from 12.8 to 12.9 #27074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build(deps): Bump CUDA from 12.8 to 12.9 #27074
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CentOS dependency Dockerfile used for native execution to install CUDA 12.9 instead of CUDA 12.8 during the build image setup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
When you have time, please sign the Presto CLA as mentioned in this comment. |
|
@steveburnett we have a corporate one. I have asked to be added. |
|
I would like to make the CUDA version used in the dependencies image configurable as an argument to the Docker build. For comparison, Velox can read We would like a similar degree of control over the CUDA version in Presto's dependencies image. It can have a default value of 12.9. Could we add that to this PR? Should be just a couple more lines of diff. cc: @paul-aiyedun @mattgara @Avinash-Raj since we were discussing this exact topic today. |
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile
Show resolved
Hide resolved
zoltan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you Simon!
Description
Motivation and Context
12.9 will soon be the minimum for latest CUDF, and has several compiler fixes.
Impact
None known.
Test Plan
Tested locally at NVIDIA.
Contributor checklist
Release Notes
Summary by Sourcery
Build: