Skip to content

Conversation

@simoneves
Copy link

@simoneves simoneves commented Feb 3, 2026

Description

Motivation and Context

12.9 will soon be the minimum for latest CUDF, and has several compiler fixes.

Impact

None known.

Test Plan

Tested locally at NVIDIA.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

  • Bump CUDA toolkit version from 12.8 to 12.9 in the CentOS dependency Dockerfile for native execution.

@simoneves simoneves requested review from a team as code owners February 3, 2026 19:31
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CentOS dependency Dockerfile used for native execution to install CUDA 12.9 instead of CUDA 12.8 during the build image setup.

File-Level Changes

Change Details Files
Bump CUDA version used in the CentOS dependency Docker image from 12.8 to 12.9.
  • Adjust the build script RUN command to invoke install_cuda with version 12.9 instead of 12.8
  • Keep the rest of the adapter and clang setup sequence unchanged to minimize behavioral differences
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 3, 2026

CLA Not Signed

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

majetideepak
majetideepak previously approved these changes Feb 3, 2026
@steveburnett
Copy link
Contributor

When you have time, please sign the Presto CLA as mentioned in this comment.

@simoneves
Copy link
Author

@steveburnett we have a corporate one. I have asked to be added.

@bdice
Copy link

bdice commented Feb 3, 2026

I would like to make the CUDA version used in the dependencies image configurable as an argument to the Docker build.

For comparison, Velox can read $CUDA_VERSION in its setup-centos-adapters.sh script (source here), so creating a Docker image with a different CUDA version just means setting that environment variable.

We would like a similar degree of control over the CUDA version in Presto's dependencies image. It can have a default value of 12.9. Could we add that to this PR? Should be just a couple more lines of diff.

cc: @paul-aiyedun @mattgara @Avinash-Raj since we were discussing this exact topic today.

Copy link
Contributor

@zoltan zoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants