-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[IGNORE] Squashed commit of cudf exchange presto setup #27077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
karthikeyann
wants to merge
1
commit into
prestodb:master
Choose a base branch
from
karthikeyann:staging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zoltan Arnold Nagy <[email protected]> Co-authored-by: Luis Garcés-Erice <[email protected]> Co-authored-by: Daniel Bauer <[email protected]>
Contributor
Reviewer's GuideEnables cuDF exchange support and profiling in Presto native execution by wiring up a cudf-exchange communicator server lifecycle, extending system configuration with a cuDF exchange port, updating docker images and entrypoint for CUDA/UCX libraries and Nsight profiling, and linking UCX into the cuDF connector path. Sequence diagram for cuDF exchange Communicator server lifecyclesequenceDiagram
participant PrestoServer
participant SystemConfig
participant CudfConfig
participant CudfRegistry as CudfRegistration
participant Communicator
participant ServerThread
PrestoServer->>PrestoServer: run()
PrestoServer->>PrestoServer: registerVeloxCudf()
PrestoServer->>SystemConfig: instance()
SystemConfig-->>PrestoServer: systemConfig
PrestoServer->>SystemConfig: values()
SystemConfig-->>PrestoServer: configValues
PrestoServer->>CudfConfig: initialize(configValues)
CudfConfig-->>PrestoServer: enabled, exchange flags
alt cuDF enabled
PrestoServer->>CudfRegistry: registerCudf()
CudfRegistry-->>PrestoServer: registration complete
alt cuDF exchange enabled
PrestoServer->>SystemConfig: cudfServerPort()
SystemConfig-->>PrestoServer: port
PrestoServer->>SystemConfig: discoveryUri()
SystemConfig-->>PrestoServer: discoveryUri
PrestoServer->>Communicator: initAndGet(port, discoveryUri)
Communicator-->>PrestoServer: communicatorInstance
PrestoServer->>ServerThread: create thread(run, communicatorInstance)
ServerThread-->>PrestoServer: communicatorThread handle
else cuDF exchange disabled
PrestoServer-->>PrestoServer: no Communicator thread
end
else cuDF disabled
PrestoServer-->>PrestoServer: cuDF and exchange not used
end
PrestoServer->>PrestoServer: registerConnectors(), run queries
PrestoServer-->>PrestoServer: shutdown sequence
PrestoServer->>PrestoServer: unregisterVeloxCudf(communicatorThread)
PrestoServer->>SystemConfig: values()
SystemConfig-->>PrestoServer: configValues
PrestoServer->>CudfConfig: check enabled
alt cuDF enabled
PrestoServer->>CudfRegistry: unregisterCudf()
CudfRegistry-->>PrestoServer: unregistration complete
alt communicatorThread exists
PrestoServer->>Communicator: getInstance()
Communicator-->>PrestoServer: communicatorInstance
PrestoServer->>Communicator: stop()
Communicator-->>PrestoServer: stopped
PrestoServer->>ServerThread: join()
ServerThread-->>PrestoServer: thread joined
else no communicatorThread
PrestoServer-->>PrestoServer: nothing to stop
end
else cuDF disabled
PrestoServer-->>PrestoServer: no cuDF teardown
end
Updated class diagram for SystemConfig and cuDF exchange configurationclassDiagram
class ConfigBase {
}
class SystemConfig {
+static constexpr string_view kCudfServerPort
+int httpServerHttpPort()
+int cudfServerPort()
+bool httpServerReusePort()
+static SystemConfig instance()
}
class CudfConfig {
+static CudfConfig getInstance()
+bool enabled
+bool exchange
}
class Communicator {
+static shared_ptr~Communicator~ initAndGet(int port, string discoveryUri)
+static shared_ptr~Communicator~ getInstance()
+void run()
+void stop()
}
class PrestoServer {
+void run()
}
ConfigBase <|-- SystemConfig
PrestoServer ..> SystemConfig : uses
PrestoServer ..> CudfConfig : configures cuDF
PrestoServer ..> Communicator : controls lifecycle
SystemConfig ..> Communicator : provides cudfServerPort
CudfConfig ..> Communicator : enables exchange
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR allow cudf-exchange to work with PR facebookincubator/velox#16214
Motivation and Context
These changes are present in ibm-research-preview branch and it's hard to update the branch, This PR will serve as placeholder and easy to update presto with a single button "Update branch" in the PR whenever Velox is advanced in Presto.
Impact
Easy to replicate working setup for cudf-exchange.
Authors:
Squashed commit of cudf exchange presto setup
Co-authored-by: Zoltan Arnold Nagy
Co-authored-by: Luis Garcés-Erice
Co-authored-by: Daniel Bauer
Summary by Sourcery
Integrate cuDF exchange support into Presto native execution, including communicator lifecycle, configuration, and container/runtime dependencies.
New Features:
Enhancements:
Build:
Deployment: