DatePicker: improve accessibility semantics, correct SR announcements and keyboard focus behavior#8513
Open
aligoknl wants to merge 2 commits intoprimefaces:masterfrom
Open
Conversation
4 tasks
|
Great PR! Since the critical accessibility issues currently in this datepicker primevue component it's breaking users which are using the keyboard and/or screen reader (or any other assistive device). Which makes it a component we currently can not use yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves DatePicker accessibility semantics, screen reader announcement, and keyboard/focus behavior.
What changed
Enterto avoid unnecessarypreventDefault.Why
These changes improve screen reader and keyboard UX while preserving existing component behavior as much as possible.
Validation
Ran DatePicker unit tests:
src/datepicker/DatePicker.spec.jspasses.Ran a11y automated tool (used axe DevTools)
Notes