fix(Dialog): provide headerId to header slot#8549
Open
hedgehog9898 wants to merge 1 commit intoprimefaces:masterfrom
Open
fix(Dialog): provide headerId to header slot#8549hedgehog9898 wants to merge 1 commit intoprimefaces:masterfrom
hedgehog9898 wants to merge 1 commit intoprimefaces:masterfrom
Conversation
- Providing headerId to header slot to make sure ariaLabelledById can be referenced in customer header slot - Extend condition for the ariaLabelledById. We won't generate ariaLabelledById if showHeader is false - Add unit tests for ariaLabelledById test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Closes Issue
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.