fix(ProgressBar): add aria-valuetext attribute #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2cfda7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/346662 |
|
🟢 golden-jobs completed with status |
…n-understandable-value-announcement
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Oct 11, 2024
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…n-understandable-value-announcement
francinelucca
deleted the
3458-prcprogressbar-best-practice-add-a-human-understandable-value-announcement
branch
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/3458
Adds
aria-valuetextattribute toProgressBarcomponent to improve accessibility for screen readers by ensuring percentage value (60% vs just 60) gets read.Changelog
New
aria-valuetextattribute toProgressBarcomponentRollout strategy
Testing & Reviewing
Verify percentage gets read on screen reader
Merge checklist