Skip to content

Conversation

randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Oct 10, 2024

Related To: https://github.com/github/collaboration-workflows-flex/issues/1297

Changelog

New

Added className prop to the ActionList.Description component for CSS Module support.

Changed

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 7b1de08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 10, 2024
@randall-krauskopf randall-krauskopf changed the title add classname prop to ActionList.Description feat(ActionList.Description): Add support for className prop Oct 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5102 October 10, 2024 14:50 Inactive
Copy link
Contributor

github-actions bot commented Oct 10, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.61 KB (-0.05% 🔽)
packages/react/dist/browser.umd.js 97.86 KB (-0.07% 🔽)

@lesliecdubs
Copy link
Member

Thanks for the contribution @randall-krauskopf! Please mark this as "ready for review" when you'd like feedback 🙏🏻

@randall-krauskopf randall-krauskopf marked this pull request as ready for review October 10, 2024 15:56
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner October 10, 2024 15:56
@randall-krauskopf
Copy link
Contributor Author

@joshblack I also added a className for this component as well.

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for this!

@joshblack joshblack added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 2742ee5 Oct 15, 2024
43 checks passed
@joshblack joshblack deleted the al-desc-classname branch October 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants