Skip to content

test(e2e): add tests for FormControl #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 1, 2024
Merged

test(e2e): add tests for FormControl #5201

merged 9 commits into from
Nov 1, 2024

Conversation

joshblack
Copy link
Member

Add e2e tests for FormControl before we begin migrating this over to CSS Modules 👀

Changelog

New

  • Add e2e test for FormControl

Changed

  • Add additional stories to FormControl for e2e testing

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to a test file

@joshblack joshblack requested a review from a team as a code owner October 31, 2024 17:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 01beae0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request skip changeset This change does not need a changelog labels Oct 31, 2024
@github-actions github-actions bot added the staff Author is a staff member label Oct 31, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 October 31, 2024 17:20 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.52 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 98.78 KB (-0.1% 🔽)

@joshblack joshblack removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 31, 2024
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 31, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 October 31, 2024 17:29 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Oct 31, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 October 31, 2024 18:34 Inactive
@primer primer bot requested a review from a team as a code owner October 31, 2024 18:41
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 31, 2024
@primer primer bot temporarily deployed to github-pages October 31, 2024 18:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 October 31, 2024 18:43 Inactive
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 1, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 November 1, 2024 15:09 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 1, 2024
@primer primer bot temporarily deployed to github-pages November 1, 2024 15:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5201 November 1, 2024 15:17 Inactive
langermank
langermank approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@joshblack joshblack added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 29a9770 Nov 1, 2024
43 checks passed
@joshblack joshblack deleted the test/add-e2e-tests-for-form-control branch November 1, 2024 17:58
@primer primer bot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @langermank