Skip to content

Toggling who can bypass the merge queue with the deployment lock #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 28, 2025

This updates the lock_release.yml workflow to toggle bypass restrictions on the merge queue.

Removing the ability to bypass the merge queue when the release is unlocked will remove the bypass check that will always be present. Helping the conductor only be able to bypass when a lock is in place.

I also added another event to unlock. When a release is released it will automatically unlock the queue.

Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 7ab7dd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Mar 28, 2025
@github-actions github-actions bot added the staff Author is a staff member label Mar 28, 2025
@@ -8,6 +8,9 @@
"features": {
"ghcr.io/devcontainers/features/sshd:1": {
"version": "latest"
},
"ghcr.io/devcontainers/features/github-cli": {
"version": "latest"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add gh cli command to the codespace

Copy link
Contributor

github-actions bot commented Mar 28, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.35 KB (0%)
packages/react/dist/browser.umd.js 105.69 KB (0%)


on:
release:
types: [released]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to unlock when a release is merged

/repos/primer/react/rulesets/4089335 \
-F "bypass_actors[][actor_id]=12276524" \
-f "bypass_actors[][actor_type]=Team" \
-f "bypass_actors[][bypass_mode]=always"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lets react-release-conductor bypass the merge queue when lock is in effect. We have to do this because if we leave the merge queue on the checkbox won't showup to bypass unless the conductor can also bypass the queue.

@github-actions github-actions bot requested a deployment to storybook-preview-5837 March 29, 2025 00:28 Abandoned
@jonrohan jonrohan marked this pull request as ready for review March 29, 2025 00:30
@jonrohan jonrohan requested a review from a team as a code owner March 29, 2025 00:30
@jonrohan jonrohan requested a review from francinelucca March 29, 2025 00:30
@jonrohan jonrohan enabled auto-merge March 29, 2025 00:30
@jonrohan jonrohan added this pull request to the merge queue Mar 29, 2025
Merged via the queue into main with commit d361e8f Mar 29, 2025
45 checks passed
@jonrohan jonrohan deleted the lock_repository_workflow_updates branch March 29, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants