-
Notifications
You must be signed in to change notification settings - Fork 604
Toggling who can bypass the merge queue with the deployment lock #5837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@@ -8,6 +8,9 @@ | |||
"features": { | |||
"ghcr.io/devcontainers/features/sshd:1": { | |||
"version": "latest" | |||
}, | |||
"ghcr.io/devcontainers/features/github-cli": { | |||
"version": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to add gh
cli command to the codespace
size-limit report 📦
|
|
||
on: | ||
release: | ||
types: [released] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to unlock when a release is merged
/repos/primer/react/rulesets/4089335 \ | ||
-F "bypass_actors[][actor_id]=12276524" \ | ||
-f "bypass_actors[][actor_type]=Team" \ | ||
-f "bypass_actors[][bypass_mode]=always" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lets react-release-conductor bypass the merge queue when lock is in effect. We have to do this because if we leave the merge queue on the checkbox won't showup to bypass unless the conductor can also bypass the queue.
This updates the lock_release.yml workflow to toggle bypass restrictions on the merge queue.
Removing the ability to bypass the merge queue when the release is unlocked will remove the bypass check that will always be present. Helping the conductor only be able to bypass when a lock is in place.
I also added another event to unlock. When a release is
released
it will automatically unlock the queue.