-
Notifications
You must be signed in to change notification settings - Fork 604
Only render a footer border on Dialogs with a scrolling body #5897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loved the implementation! 🚀
Closes https://github.com/github/primer/issues/4989
Kapture.2025-04-07.at.15.12.53.mp4
Changelog
New
Changed
animation-timeline
and itsscroll()
functionRemoved
Rollout strategy
Testing & Reviewing
Merge checklist