Skip to content

Only render a footer border on Dialogs with a scrolling body #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mperrotti
Copy link
Contributor

Closes https://github.com/github/primer/issues/4989

Kapture.2025-04-07.at.15.12.53.mp4

Changelog

New

Changed

  • Only render a border between the dialog body and the dialog footer in browsers that support CSS animation-timeline and its scroll() function

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner April 7, 2025 19:17
@mperrotti mperrotti requested a review from hectahertz April 7, 2025 19:17
Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 3f6bfce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Apr 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.62 KB (+0.17% 🔺)
packages/react/dist/browser.umd.js 104.89 KB (+0.1% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5897 April 9, 2025 13:53 Inactive
@mperrotti mperrotti changed the title Only render a footer border on dialogs with a scrolling body Only render a footer border on Dialogs with a scrolling body Apr 9, 2025
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved the implementation! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants