Skip to content

feat: add support for size to Blankslate #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: add support for size to Blankslate #5899

wants to merge 12 commits into from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Apr 7, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4863

Changelog

New

  • Add support for size to Blankslate

Changed

  • Update overall styling to align with intended usage in Figma

Removed

Rollout strategy

  • Minor release

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.7 KB (0%)
packages/react/dist/browser.umd.js 102.99 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5899 April 7, 2025 21:56 Inactive
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a99df82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5899 April 8, 2025 14:31 Inactive
@joshblack joshblack changed the title feat: add support for variant to Blankslate feat: add support for size to Blankslate Apr 11, 2025
@joshblack joshblack marked this pull request as ready for review April 11, 2025 15:54
@joshblack joshblack requested a review from a team as a code owner April 11, 2025 15:54
@github-actions github-actions bot requested a deployment to storybook-preview-5899 April 11, 2025 15:54 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5899 April 11, 2025 16:11 Inactive
@primer primer bot requested a review from a team as a code owner April 11, 2025 16:19
@primer primer bot requested a review from emilybrick April 11, 2025 16:19
@github-actions github-actions bot requested a deployment to storybook-preview-5899 April 11, 2025 16:23 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5899 April 11, 2025 16:37 Inactive
lukasoppermann
lukasoppermann approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Is there any way we can get it out of experimental? I mean, is it really experimental?

lukasoppermann
lukasoppermann requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed that the icon size for small should be 24px, but it is 16 at the moment. Can we change this?

francinelucca
francinelucca approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the visual changes are expected 👀

@lukasoppermann
Copy link
Contributor

Some more updates were added to the Figma version, specifically to the small variant: https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=4398-2383&t=T3iXg81O8v9mxzrZ-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann requested changes

@francinelucca francinelucca francinelucca approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @lukasoppermann @francinelucca