Report reason for plugin reflection failure when using testing component

[jasonkuhrt]

Perceived Problem

• via @luhagel
• in https://github.com/graphql-nexus/nexus/pull/1296#issuecomment-664808856

Ideas / Proposed Solution(s)

• tbd
• should be a matter of not swallowing errors between processes

Waiting for upstream

• Swallowed error in beforeAll lifecycle when a shared reference is held in afterAll jestjs/jest#10332

[Weakky]

Spent some time today investigating that. I removed the fatal inside createTestContext and instead thrown the error. However, that doesn't fix everything.

I'm not sure exactly yet what causes the error to be swallowed, but as soon as you share the ctx reference between the beforeAll and afterAll lifecycle, the error is swallowed and the test crashes because the test accesses ctx.* yet ctx is undefined as createTestContext threw

[jasonkuhrt]

To remove a variable, what happens when simplified to:

beforeAll(async () => {
  await createTestContext()
})

[Weakky]

Yeah yeah this works, as mentioned it only happens when sharing the ctx reference between the afterAll and beforeAll.

You can even use the beforeAll and afterAll lifecycle together but not use the ctx reference inside afterAll and the error won't be swallowed. Wondering if this is not a jest bug

[jasonkuhrt]

If we can find a minimal repro of the issue let's open an issue for Jest about it. Meanwhile/Also wondering what the merits of something like this are:

import { ctx, setup } from 'nexus/testing'

beforeAll(async () => {
  await setup()
  await ctx.app.start()
})

afterAll(async () => {
  await ctx.app.stop()
})

Behind the scenes we could maybe do something like:

export const ctx = {}

export async function setup() {
  const ... await ...
  Object.assign(ctx, ...)
}

1. Would we generally want this?
2. Would this solve our current immediate problem?

[Weakky]

Here's a minimal repro

let ctx: { titi: string }

beforeAll(() => {
  throw new Error('should stop all tests')
  ctx = { titi: "" }
})

afterAll(async () => {
  console.log(ctx.titi)
})

test('something', () => {
  expect(1 + 1).toEqual(2)
})

Would this solve our current immediate problem

Not sure it would solve it, I don't understand the root cause for the problem right now :/. I think it has to do with the crazy stuff jest's doing with the lifecycles

[Weakky]

Upstream issue can be found here: jestjs/jest#10332. I'm a bit worried this takes forever to be solved