This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add rustdocflags config for macos in Makefile
#1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
force-pushed
the
fix/rustdocflags-for-macos
branch
from
7285e42 to
da66a8f
Compare
han0110
force-pushed
the
fix/rustdocflags-for-macos
branch
from
da66a8f to
7af9746
Compare
hero78119
approved these changes
May 16, 2023
ChihChengLiang
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
rustdocflagsoverride inMakefilewhen it's macos to make doc test work.Note that
config.tomldoesn't support to specifyrustdocflagsunder[target.'cfg(target_os = "macos")'](see rust-lang/cargo#11323) so we have to use command line override to add it manually.Issue Link
Resolves #1410
Type of change
How Has This Been Tested?
On macos, run
make test_doc.